Added simple Redis storage #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
guillaumepotier
changed the title
|
@guillaumepotier thanks very much for making this pull request! Can you make this storage system pass |
- fixes 'botkit undefined' error when using
webhooks and slash commands
|
Hi, great to have some tests. I'm looking at them right now. I noticed thanks to the tests that {
"id1": {"id": "id1", "foo": "bar"},
"id2": {"id": "id2", "bar": "baz"}
}I'll update my |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
Following #37 here is a humble submission for a simple Redis storage.
I'm just starting with botkit (and thanks a lot) and I already know I cannot use file storage since my bots would live in various VMs.
I use node redis (
npm install redis --save) and hashes sets (that have O(1) complexity likeSETandGETand is a lot easier forall()method O(N) on the set vs. O(N) on the entire database forKEYS).This is not tested in production (yet) and should not make any BC Break (just moved
simple_storage.jsinto subdir if some other storages are going to be in the repo).Tried to update a bit the README with my french background..
Please let me know if some things are wrong or missing, won't change my life if not merged, but could be nice for a broader adoption of the lib.
Best